Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce logging level of CACHE_MISS <GitHub Issue #833> #844

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

papaya2k
Copy link
Contributor

@papaya2k papaya2k commented Jul 23, 2024

Addresses GitHub Issue #833 by reducing the logging level of a CACHE_MISS in the AuthenticationResultSupplier to debug level.

Avery-Dunn:

I agree that a cache miss exception should cause a debug log, since it doesn't necessarily mean that something wrong. It'll be a quick fix so will likely be in our next release, and I'll update this thread once we have some ETAs

Without this patch, the logging output is overly verbose about CACHE_MISS events. This should resolve that issue by changing the logging level.

@papaya2k papaya2k marked this pull request as ready for review July 23, 2024 20:36
@papaya2k papaya2k requested a review from a team as a code owner July 23, 2024 20:36
@papaya2k papaya2k force-pushed the cache-miss-logging-fix branch from 5643faf to a8039e6 Compare July 23, 2024 21:43
Addresses GitHub Issue AzureAD#833 by reducing the logging level of a
CACHE_MISS in the AuthenticationResultSupplier to debug level.
@papaya2k papaya2k force-pushed the cache-miss-logging-fix branch from a8039e6 to 361ec5f Compare July 23, 2024 21:46
@Avery-Dunn
Copy link
Collaborator

Looks good to me @papaya2k, thanks for fixing this!

@Avery-Dunn Avery-Dunn merged commit 006abce into AzureAD:dev Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants