Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensibility Testing: Refactor #3011

Merged
merged 13 commits into from
Nov 21, 2024
Merged

Extensibility Testing: Refactor #3011

merged 13 commits into from
Nov 21, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Nov 16, 2024

Extensibility Testing: Refactor

  • Refactored the ValidationError and its subclasses to align optional parameters and ensure the GetException method sets the ValidationError parameter required to provide a stack trace.
  • Adjusted existing delegates to use the updated ValidationError parameters and updates the identity comparer to check for the exception's stack trace when comparing validation errors.
  • Moved custom exceptions and validation errors to a specific folder for extensibility testing, and the custom issuer validation delegates file is renamed to split the other validation aspects
  • Added new custom exceptions for the remaining validations
  • Removed the old Audience and Lifetime extensibility tests in favour of unifying the approach using the issuer extensibility tests as a template

Note: most of the files changed are due to the updated parameter order in ValidationError and subclasses.

Part of #2711

…s and ensure GetException sets the ValidationError parameter required to provide a stack trace
…r extensibility testing. Renamed custom issuer validation delegates file to split the other validation aspects
…ifying the approach using the issuer extensibility tests as template
@iNinja iNinja requested a review from a team as a code owner November 16, 2024 20:44
@iNinja iNinja merged commit 90173bf into dev Nov 21, 2024
5 of 6 checks passed
@iNinja iNinja deleted the iinglese/extensibility-tests-base branch November 25, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants