SAML and SAML2 new model validation: Token Replay #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o match existing behaviour. Added comparison tests between new validation model and the legacy one
…lidation for after the token is created
|
Looks like the tests are failing? is that expected? |
Probably not 😄. Apparently when I merged the signature validation code, I mistakenly left the signature validation after the issuer signing key one. This failure was then hidden by the issue we had with the Abstractions assemblies signature that was failing all builds. |
...icrosoft.IdentityModel.Tokens.Saml/Saml2/Saml2SecurityTokenHandler.ValidateToken.Internal.cs
Show resolved
Hide resolved
JoshLozensky
approved these changes
Nov 19, 2024
westin-m
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SAML and SAML2 new model validation: Token Replay
Part of #2711