Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore skipped test: ReferenceCountingTest_MultiThreaded #2952

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Oct 30, 2024

This test was previously skipped due to "too long". How long is too long? This takes an average of 300 ms to complete when I run it locally, aka 0.3 s.

@kllysng kllysng requested a review from a team as a code owner October 30, 2024 18:08
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @kellyyangsong

@kllysng kllysng merged commit 160a81d into dev Oct 30, 2024
5 checks passed
@kllysng kllysng deleted the kellysong/restore-rCTMultiThreaded branch October 30, 2024 18:28
@jennyf19 jennyf19 added this to the 8.2.0 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants