Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests: Issuer signing key #2927

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Oct 18, 2024

Regression tests: Issuer signing key

  • Added internal TimeProvider to TokenValidationParameters to simplify testing of expired signing key scenarios
  • Added regression/comparison tests for issuer signing key scenarios

Part of #2711

@iNinja iNinja requested a review from a team as a code owner October 18, 2024 14:42
Copy link
Contributor

@FuPingFranco FuPingFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iNinja iNinja merged commit a76f215 into dev Oct 22, 2024
5 checks passed
@alexmurari alexmurari mentioned this pull request Oct 30, 2024
5 tasks
@iNinja iNinja deleted the iinglese/regression-tests-issuer-signing-key branch November 15, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add comparison tests for IssuerSigningKey validation in new validation model
4 participants