-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust for RefreshInterval not influencing AutomaticRefreshInterval. #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
reviewed
Oct 3, 2024
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
pmaytak
reviewed
Oct 3, 2024
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
The test is failing
|
Add random % of AutomaticRefreshInterval to avoid spike in trafic in all cases
brentschmaltz
force-pushed
the
brentsch/RequestRefresh
branch
from
October 3, 2024 23:49
3b5de98
to
dcb785c
Compare
msbw2
reviewed
Oct 4, 2024
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Outdated
Show resolved
Hide resolved
pmaytak
approved these changes
Oct 4, 2024
pmaytak
reviewed
Oct 4, 2024
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
pmaytak
reviewed
Oct 4, 2024
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
brentschmaltz
force-pushed
the
brentsch/RequestRefresh
branch
from
October 4, 2024 23:23
d6777c7
to
e9f4fc3
Compare
jennyf19
reviewed
Oct 4, 2024
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
jennyf19
approved these changes
Oct 4, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed last instance of RefreshInterval influencing AutomaticRefreshInterval.
Remove dead code in ConfigurationManager.
There was code inside a null check that would not get executed, it was removed.