Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensibility tests: Lifetime #2867

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Extensibility tests: Lifetime #2867

merged 5 commits into from
Oct 21, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Oct 3, 2024 •
edited
Loading

Extensibility tests: Lifetime

  • Added extensibility tests for JWT lifetime validation

Part of #2711

@iNinja iNinja requested a review from a team as a code owner October 3, 2024 14:43
@iNinja iNinja marked this pull request as draft October 3, 2024 16:50
@iNinja
Copy link
Contributor Author

iNinja commented Oct 3, 2024

Turning to draft until we address the exception extensibility situation.

@iNinja iNinja linked an issue Oct 17, 2024 that may be closed by this pull request
Add extensibility tests for Lifetime validation in JsonWebTokenHandler #2910
Closed
@iNinja iNinja removed a link to an issue Oct 17, 2024
Add extensibility tests for Lifetime validation in JsonWebTokenHandler #2910
Closed
@iNinja iNinja linked an issue Oct 17, 2024 that may be closed by this pull request
Add extensibility tests for Lifetime validation in JsonWebTokenHandler #2909
Closed
@iNinja iNinja marked this pull request as ready for review October 18, 2024 13:37
jennyf19
jennyf19 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

brentschmaltz
brentschmaltz approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pull this in and i will refactor common parts when i push the issuer delegate extensibility tests.

@iNinja iNinja merged commit c67c8b5 into dev Oct 21, 2024
5 checks passed
@iNinja iNinja deleted the iinglese/extensibility-tests-lifetime branch November 15, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add extensibility tests for Lifetime validation in JsonWebTokenHandler
3 participants
@iNinja @brentschmaltz @jennyf19