Extensibility tests: Audience #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNinja
commented
Oct 2, 2024
...el.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.Extensibility.cs
Outdated
Show resolved
Hide resolved
… Updated Audience extensibility tests.
jennyf19
reviewed
Oct 16, 2024
| @@ -15,6 +15,8 @@ internal static class LogMessages | |||
| // general | |||
| public const string IDX10000 = "IDX10000: The parameter '{0}' cannot be a 'null' or an empty object. "; | |||
| public const string IDX10001 = "IDX10001: Invalid argument '{0}'. Argument must be of type '{1}'."; | |||
| // TODO: Confirm the wording of this message. Possibly create a wiki page to refer users to for more information. | |||
There was a problem hiding this comment.
Let make sure we have a tracking GitHub issue, otherwise we might forget. agree on an aka.ms link
jennyf19
approved these changes
Oct 16, 2024
...el.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.Extensibility.cs
Outdated
Show resolved
Hide resolved
...el.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.Extensibility.cs
Outdated
Show resolved
Hide resolved
...el.JsonWebTokens.Tests/JsonWebTokenHandler.ValidateTokenAsyncTests.Audience.Extensibility.cs
Show resolved
Hide resolved
…l objects added to the theorydata object.
# Conflicts: # src/Microsoft.IdentityModel.Tokens/InternalAPI.Unshipped.txt # src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/AudienceValidationError.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensibility tests: Audience
Part of #2711