Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValidateJsonWebTokenClaimMapping Flaky Test 🐞 #2859

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Oct 1, 2024

Fixes #2840

Please see #2840 (comment) for root cause and more details

@kllysng kllysng requested a review from a team as a code owner October 1, 2024 22:58
@msbw2
Copy link
Contributor

msbw2 commented Oct 1, 2024

I don't understand the test. The types should be changed to IReadOnlyDictionary<...> and these tests removed since they don't really add any value and yet introduce flakiness.

@kllysng kllysng merged commit 623ce69 into dev Oct 2, 2024
6 checks passed
@kllysng kllysng deleted the kellysong/flaky-claimMapping-test branch October 2, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants