-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FixedTimeEquals in NETCore targets #2857
Conversation
Could you also run a small benchmark? |
A similar change is needed for the ReadOnlySpan overload. |
Patche-2_Robledo6 |
Are we okay with these benchmarks? Not sure if the results are as expected 🤔 |
Reopening this because our current code is getting optimized, which we don't want. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of these methods are covered by tests?
Yes, there is already coverage. |
Closes #2825
There is another class in wilson named CryptographicOperations, so the fully qualified name is necessary.
The following results are after applying NoOptimization