Uses spans for issuer comparison and fixes prior index out of range error #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… index out of range exception
test/Microsoft.IdentityModel.Validators.Tests/AadIssuerValidatorTests.cs
Show resolved
Hide resolved
SaurabhMSFT
reviewed
Sep 19, 2024
src/Microsoft.IdentityModel.Validators/AadIssuerValidator/AadIssuerValidator.cs
Show resolved
Hide resolved
kllysng
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Improves performance during issuer validation by replacing string comparison with span comparison.
What?
The performance improvements were originally introduced in this PR that had to be reverted due an index out of range error. This PR reintroduces the changes and addresses the error.