Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 9.0.100-rc.1 #2821

Merged
merged 15 commits into from
Sep 21, 2024
Merged

Update to 9.0.100-rc.1 #2821

merged 15 commits into from
Sep 21, 2024

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Sep 10, 2024 •
edited
Loading

Fixes #2789

@kllysng kllysng force-pushed the kellysong/update-9.0.1prev branch from a9bd969 to 73ea939 Compare September 18, 2024 01:12
@kllysng kllysng force-pushed the kellysong/update-9.0.1prev branch from 73ea939 to 53e456b Compare September 18, 2024 01:31
@kllysng kllysng marked this pull request as ready for review September 19, 2024 19:21
@kllysng kllysng requested a review from a team as a code owner September 19, 2024 19:21
pmaytak
pmaytak reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main suggestion is to refactor the certificate creation into a separate helper. This will also help, for example, if in the future we decide to use Microsoft.Bcl.Cryptography package, then the code change will only have to be in one place.

@kllysng kllysng changed the title Update to 9.0.100-preview.7.24407.12 Update to 9.0.100-rc.1 Sep 19, 2024
@kllysng kllysng mentioned this pull request Sep 20, 2024
Closed
brentschmaltz
brentschmaltz approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for an additional API (optional)

@kllysng kllysng merged commit a9e95ce into dev Sep 21, 2024
5 of 6 checks passed
@kllysng kllysng deleted the kellysong/update-9.0.1prev branch September 21, 2024 00:03
@kllysng kllysng mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 left review comments

@msbw2 msbw2 msbw2 approved these changes

@pmaytak pmaytak pmaytak approved these changes

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to 9.0.100-rc1
5 participants
@kllysng @brentschmaltz @jennyf19 @pmaytak @msbw2