Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ArgumentNullException type with ValidationError #2818

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Added ArgumentNullException type with ValidationError #2818

merged 6 commits into from
Sep 13, 2024

Conversation

iNinja
Copy link
Contributor

@iNinja iNinja commented Sep 9, 2024 •
edited
Loading

Added ArgumentNullException type with ValidationError

  • Added ISecurityTokenException interface to align system exceptions and custom exceptions under a single entry point to inject the validation error used to return the stack traces.
  • Added SecurityTokenArgumentNullException implementing the interface.
  • Updated usage of ArgumentNullException in code and tests to consume the new type.

Part of #2711

@iNinja iNinja requested a review from a team as a code owner September 9, 2024 18:41
@iNinja
Removed code used to highlight how Nullables work during a call
d871edb
@iNinja
Fixed typo
42bdb96
@iNinja
Merge branch 'dev' into iinglese/argumentnullexception-with-validatio…
981b4b8 
…nerror

# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/Validation/Results/Details/ValidationError.cs
keegan-caruso
keegan-caruso approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@keegan-caruso keegan-caruso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fill out the one comment, otherwise looks good.

@iNinja iNinja merged commit 79974de into dev Sep 13, 2024
6 checks passed
@pmaytak pmaytak mentioned this pull request Oct 8, 2024
Merged
@iNinja iNinja deleted the iinglese/argumentnullexception-with-validationerror branch November 15, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@FuPingFranco FuPingFranco FuPingFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iNinja @FuPingFranco @keegan-caruso