New token validation path: Renamed result types #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValidationResult -> ValidatedToken ExceptionDetails -> ValidationError Result -> ValidationResult
src/Microsoft.IdentityModel.Tokens/Validation/Results/ValidationResult.cs
Show resolved
Hide resolved
|
Git did a whole mess due to the fact that I renamed a different file to the name that a previous one had. So now it is comparing OldA against newB. This PR made no changes to the renamed types, only to the references in other files. |
keegan-caruso
approved these changes
Sep 6, 2024
brentschmaltz
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New token validation path: Renamed result types
Updated the type names for the new token validation path to prevent future clashes with the type name "Result".
ValidationResult -> ValidatedToken
ExceptionDetails -> ValidationError
Result -> ValidationResult
Validators and delegates now return ValidationResult.
ValidateTokenAsyncnow returns ValidationResult<ValidatedToken>Failed validations now return a ValidationError within
UnwrapError()Part of #2711