Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TimeProvider on New Model #2813

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Enable TimeProvider on New Model #2813

merged 6 commits into from
Sep 17, 2024

Conversation

FuPingFranco
Copy link
Contributor

Enable TimeProvider on New Model

Description

Enable TimeProvider on new Wilson model.

@iNinja
Copy link
Contributor

iNinja commented Sep 6, 2024

This looks good so far. If you could add the FakeTimeProvider to the tests to prevent any flakiness, it would be perfect.

@FuPingFranco FuPingFranco marked this pull request as ready for review September 17, 2024 00:10
@FuPingFranco FuPingFranco requested a review from a team as a code owner September 17, 2024 00:10
@FuPingFranco
Copy link
Contributor Author

This looks good so far. If you could add the FakeTimeProvider to the tests to prevent any flakiness, it would be perfect.

I updated our new validation unit tests that required DateTime.UtcNow to use TimeProvider but decided to implement a MockTimeProvider instead as the FakeTimeProvider raises a new warning due to it being untested for net462.

@keegan-caruso
Copy link
Contributor

This looks good so far. If you could add the FakeTimeProvider to the tests to prevent any flakiness, it would be perfect.

I updated our new validation unit tests that required DateTime.UtcNow to use TimeProvider but decided to implement a MockTimeProvider instead as the FakeTimeProvider raises a new warning due to it being untested for net462.

I don't understand, https://www.nuget.org/packages/Microsoft.Extensions.TimeProvider.Testing/8.9.1#dependencies-body-tab

Has a net462 target.

iNinja
iNinja approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@iNinja iNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Minor comment.

build/dependenciesTest.props Outdated Show resolved Hide resolved
@FuPingFranco FuPingFranco merged commit d7a6547 into dev Sep 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@iNinja iNinja iNinja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FuPingFranco @iNinja @keegan-caruso