Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lock when creating a SignatureProvider #2788

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Remove lock when creating a SignatureProvider #2788

merged 1 commit into from
Aug 21, 2024

Conversation

brentschmaltz
Copy link
Member

Remove the lock on creating a SignatureProvider an allow a rare case where a SignatureProvider is created and not cached.

@brentschmaltz brentschmaltz requested a review from a team as a code owner August 20, 2024 19:07
jennyf19
jennyf19 approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 added this to the 8.0.2 milestone Aug 21, 2024
@brentschmaltz brentschmaltz merged commit 1e23cef into dev Aug 21, 2024
6 checks passed
@brentschmaltz brentschmaltz deleted the brentsch/LockOnSignatureProviderCreation branch August 21, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@brentschmaltz @jennyf19 @keegan-caruso @HP712