Validate IssuerSigningKey: Refactor to use ValidationParameters over TVP #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuPingFranco
reviewed
Aug 6, 2024
src/Microsoft.IdentityModel.Tokens/Validation/Validators.IssuerSigningKey.cs
Outdated
Show resolved
Hide resolved
FuPingFranco
reviewed
Aug 6, 2024
src/Microsoft.IdentityModel.Tokens/Validation/Validators.IssuerSigningKey.cs
Show resolved
Hide resolved
FuPingFranco
approved these changes
Aug 6, 2024
sruke
reviewed
Aug 6, 2024
src/Microsoft.IdentityModel.Tokens/Validation/Validators.IssuerSigningKey.cs
Outdated
Show resolved
Hide resolved
kllysng
reviewed
Aug 6, 2024
| public IssuerSigningKeyValidatorDelegate IssuerSigningKeyValidator | ||
| { | ||
| get => _issuerSigningKeyValidator; | ||
| set => _issuerSigningKeyValidator = value ?? throw new ArgumentNullException(nameof(value), "IssuerSigningKeyValidator cannot be set as null."); |
There was a problem hiding this comment.
Consider creating a log message.
There was a problem hiding this comment.
We have a number of similar scenarios. I will definitely look into generalising them and reusing a log message or creating a new one as part of this stream.
…rSigningKey.cs Co-authored-by: sruthikeerthi <73967733+sruke@users.noreply.github.com>
JoshLozensky
reviewed
Aug 6, 2024
src/Microsoft.IdentityModel.Tokens/Validation/Validators.IssuerSigningKey.cs
Outdated
Show resolved
Hide resolved
sruke
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate IssuerSigningKey: Refactor to use ValidationParameters over TVP
Description
Replaced use of TokenValidationParameters with ValidationParameters inside ValidateIssuerSecurityKey and updated tests accordingly.
Removed version of the method that takes BaseConfiguration as it is not used, and the exposed delegate does not contain it either.
Part of #2711