Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable EnforceCodeStyleInBuild and fix findings #2763

Merged
merged 8 commits into from
Aug 6, 2024
Merged

Enable EnforceCodeStyleInBuild and fix findings #2763

merged 8 commits into from
Aug 6, 2024

Conversation

keegan-caruso
Copy link
Contributor

Enable EnforceCodeStyleInBuild and fix findings

Have to enable GenerateDocumentationFile for test csproj to work around
dotnet/roslyn#41640

Fixes #2603

Keegan Caruso added 2 commits August 5, 2024 19:40
Enable EnforceCodeStyleInBuild and fix findings
7fb0c2d 
Have to enable GenerateDocumentationFile for test csproj to work around
dotnet/roslyn#41640
Fix up code generated by roslyn fixer
399fcd8
@keegan-caruso keegan-caruso requested a review from a team as a code owner August 6, 2024 02:56
@armandRobled
Copy link

armandRobled commented Aug 6, 2024 via email

@armandRobled
Copy link

armandRobled commented Aug 6, 2024 via email

iNinja
iNinja approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@iNinja iNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears we have a rule in our Wilson Github Action test that is failing due to a few files not having the usual header. From looking at them, it would appear that they may be exceptions to the rule.

@armandRobled
Copy link

armandRobled commented Aug 6, 2024 via email

Updates for file headers
73ca829 
Don't consider GlobalSuppressions.cs, or TrimmingAttributes.cs
@keegan-caruso
Copy link
Contributor Author

Thanks @iNinja, I removed those files from the editorconfig rule for file headers.

pmaytak
pmaytak reviewed Aug 6, 2024
View reviewed changes
.editorconfig Show resolved Hide resolved
@keegan-caruso keegan-caruso merged commit 15e26cf into dev Aug 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaytak pmaytak pmaytak approved these changes

@iNinja iNinja iNinja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Enforce Code Style In Build
4 participants
@keegan-caruso @armandRobled @iNinja @pmaytak