Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-factor Issuer Validator to Follow New Validation Model #2759

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Re-factor Issuer Validator to Follow New Validation Model #2759

merged 4 commits into from
Aug 6, 2024

Conversation

FuPingFranco
Copy link
Contributor

Re-factor Issuer Validator to Follow New Validation Model

Description

  • Removed checks for ValidIssuer from Issuer validation.
  • Moved away from using TokenValidationParameters in favor of the new ValidationParameters.
  • Added new tests in ValidationParameters class.
  • Fixed minor inconsistencies on the code.

@FuPingFranco FuPingFranco requested a review from a team as a code owner August 1, 2024 01:52
iNinja
iNinja previously approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@iNinja iNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change and we're good.

src/Microsoft.IdentityModel.Tokens/Validation/Validators.Issuer.cs Outdated Show resolved Hide resolved
brentschmaltz
brentschmaltz approved these changes Aug 1, 2024 •
edited
Loading
View reviewed changes
@brentschmaltz brentschmaltz self-requested a review August 1, 2024 16:54
brentschmaltz
brentschmaltz previously requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties that return IList should not be settable.
If the property can be null, for a successful validation, use a delayed creation.

@iNinja iNinja dismissed their stale review August 6, 2024 09:50

There are changes still unaddressed.

@FuPingFranco @iNinja
Addressed PR feedback, updated tests. (#2766)
74c0145 
Co-authored-by: Ignacio Inglese <iinglese@microsoft.com>
@FuPingFranco FuPingFranco dismissed brentschmaltz’s stale review August 6, 2024 15:21

Changes have been made, need to dismiss review in order to unblock other work.

@FuPingFranco FuPingFranco merged commit dac7a56 into dev Aug 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhMSFT SaurabhMSFT SaurabhMSFT approved these changes

@iNinja iNinja iNinja approved these changes

@brentschmaltz brentschmaltz brentschmaltz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FuPingFranco @iNinja @brentschmaltz @SaurabhMSFT