Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate #2758

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate #2758

merged 3 commits into from
Aug 6, 2024

Conversation

FuPingFranco
Copy link
Contributor

@FuPingFranco FuPingFranco commented Jul 31, 2024 •
edited
Loading

Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate.

Description

  • Removed delegate checks from Audience validation.
  • Moved away from using TokenValidationParameters in favor of the new ValidationParameters.
  • Updated unit tests and added new tests in ValidationParameters class.
  • Fixed minor inconsistencies on the code.

@FuPingFranco FuPingFranco requested a review from a team as a code owner July 31, 2024 21:32
@FuPingFranco FuPingFranco changed the title Remove Delegate Checks in Default Audience Validator and Prevents Null Setting of Delegates Remove Delegate Checks Audience Validator and Prevents Null Setting of Delegate Jul 31, 2024
jennyf19
jennyf19 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

iNinja
iNinja approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@iNinja iNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, then looks good.

src/Microsoft.IdentityModel.Tokens/Validation/Validators.Audience.cs Outdated Show resolved Hide resolved
brentschmaltz
brentschmaltz previously requested changes Aug 1, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 'Set' from properties that return an IList

@FuPingFranco @iNinja
Address PR feedback. (#2765)
0cc32fc 
* Addressed PR feedback. Updated tests

* Removed exception from documentation

* Updated TokenType tests

---------

Co-authored-by: Ignacio Inglese <iinglese@microsoft.com>
@FuPingFranco FuPingFranco dismissed brentschmaltz’s stale review August 6, 2024 15:20

Changes have been implemented, need to dismiss review to unblock work ahead.

@FuPingFranco FuPingFranco merged commit c6f83c4 into dev Aug 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentschmaltz brentschmaltz brentschmaltz left review comments

@jennyf19 jennyf19 jennyf19 approved these changes

@iNinja iNinja iNinja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FuPingFranco @iNinja @brentschmaltz @jennyf19