New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature Validation: Remove exceptions #2757

Merged

iNinja merged 7 commits into dev from iinglese/validate-signature

Aug 6, 2024

Contributor

iNinja commented Jul 31, 2024

Signature Validation: Remove exceptions

You've read the Contributor Guide and Code of Conduct.
You've included unit or integration tests for your change, where applicable.
You've included inline docs for your change, where applicable.
If any gains or losses in performance are possible, you've included benchmarks for your changes. More info
There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Part of the ValidateJWS/JWEAsync, removed exception throwing from signature validation. Refactored code and simplified some paths along the way.

iNinja added 3 commits

July 31, 2024 15:24


          Refactored ValidateSignature to remove exceptions and some logs

0a84572


          Updated documentation. Added null checks for parameters. Added base f…

b68f179

…or tests


          Added test

a96eb31

iNinja requested a review from a team as a code owner

July 31, 2024 17:10

jennyf19 reviewed

View reviewed changes

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved


          Add tests

cec927c

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/SignatureValidationResult.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/SignatureValidationResult.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs Outdated Show resolved Hide resolved

brentschmaltz reviewed

View reviewed changes

src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs Show resolved Hide resolved


          Addresed PR feedback

0fd03ab

jennyf19 approved these changes

View reviewed changes

Collaborator

jennyf19 left a comment

iNinja added 2 commits

August 6, 2024 16:47


          Merge branch 'dev' into iinglese/validate-signature

6651ddf

# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs


          Merge branch 'dev' into iinglese/validate-signature

ce49c84

# Conflicts:
#	src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs

FuPingFranco approved these changes

View reviewed changes

Contributor

FuPingFranco left a comment

LGTM

iNinja merged commit 4849a81 into dev

6 checks passed

kllysng reviewed

View reviewed changes

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs Show resolved Hide resolved

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.ValidateSignature.cs Show resolved Hide resolved

iNinja deleted the iinglese/validate-signature branch

November 15, 2024 12:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet