Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonWebKeySet stores the String it was created with #2755

Merged
merged 16 commits into from
Aug 6, 2024

Conversation

westin-m
Copy link
Contributor

Store the original string the JsonWebKeySet was created with

@westin-m westin-m requested a review from a team as a code owner July 30, 2024 22:44
@pmaytak
Copy link
Contributor

pmaytak commented Jul 31, 2024

Just for my understanding, what's the reasoning for keeping the original string? When would it ever be used for, if it's already parsed into properties?

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@westin-m
Copy link
Contributor Author

westin-m commented Aug 1, 2024

Just for my understanding, what's the reasoning for keeping the original string? When would it ever be used for, if it's already parsed into properties?

@pmaytak The original string can be used by the OIDC config manager to, on L2 cache reads, deserialize and store the keys alongside the metadata document without needing the JWKs to serialize the security keys

@pmaytak
Copy link
Contributor

pmaytak commented Aug 1, 2024

Just for my understanding, what's the reasoning for keeping the original string? When would it ever be used for, if it's already parsed into properties?

@pmaytak The original string can be used by the OIDC config manager to, on L2 cache reads, deserialize and store the keys alongside the metadata document without needing the JWKs to serialize the security keys

@westin-m But we can add additional keys and remove keys from Keys collection. So is there a benefit then to keeping the original JSON string if it can get out of sync? If we're serializing the key set, we'd want to serialize the current Keys always anyway?

westin-m and others added 2 commits August 5, 2024 16:18
Co-authored-by: Keegan Caruso <Keegan.Caruso@microsoft.com>
…eoryData.cs

Co-authored-by: Keegan Caruso <Keegan.Caruso@microsoft.com>
Co-authored-by: Keegan Caruso <Keegan.Caruso@microsoft.com>
@westin-m westin-m merged commit 12fe1ec into dev Aug 6, 2024
6 checks passed
@westin-m westin-m added this to the 8.0.2 milestone Aug 19, 2024
@westin-m westin-m deleted the westin/storeOriginalString branch October 17, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants