-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonWebKeySet stores the String it was created with #2755
Conversation
...soft.IdentityModel.Protocols.OpenIdConnect.Tests/OpenIdConnectConfigurationRetrieverTests.cs
Show resolved
Hide resolved
Just for my understanding, what's the reasoning for keeping the original string? When would it ever be used for, if it's already parsed into properties? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmaytak The original string can be used by the OIDC config manager to, on L2 cache reads, deserialize and store the keys alongside the metadata document without needing the JWKs to serialize the security keys |
@westin-m But we can add additional keys and remove keys from |
...soft.IdentityModel.Protocols.OpenIdConnect.Tests/OpenIdConnectConfigurationRetrieverTests.cs
Show resolved
Hide resolved
test/Microsoft.IdentityModel.Tokens.Tests/JsonWebKeySetTests.cs
Outdated
Show resolved
Hide resolved
This reverts commit 667ad73.
test/Microsoft.IdentityModel.Tokens.Tests/Json/JsonWebKeySetTheoryData.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Keegan Caruso <Keegan.Caruso@microsoft.com>
…eoryData.cs Co-authored-by: Keegan Caruso <Keegan.Caruso@microsoft.com>
Co-authored-by: Keegan Caruso <Keegan.Caruso@microsoft.com>
Store the original string the JsonWebKeySet was created with