Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Delegate Checks in Multiple Validators and Prevents Null Setting of Delegates #2725

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Remove Delegate Checks in Multiple Validators and Prevents Null Setting of Delegates #2725

merged 5 commits into from
Jul 27, 2024

Conversation

FuPingFranco
Copy link
Contributor

@FuPingFranco FuPingFranco commented Jul 16, 2024 •
edited
Loading

Remove Delegate Checks in Multiple Validators and Prevents Null Setting of Delegates.

Description

  • Removed delegate checks from our default token type, lifetime and token replay validation.
  • Moved away from using TokenValidationParameters in favor of the new ValidationParameters.
  • Updated unit tests and added new tests for ValidationParameters class.
  • Fixed minor inconsistencies on the code.

@FuPingFranco FuPingFranco requested a review from a team as a code owner July 16, 2024 22:49
@FuPingFranco FuPingFranco changed the title Removed Delegate Checks from Token Type Validation. Removed Delegate Checks from Multiple Validators and Prevents Null Setting of Delegates Jul 24, 2024
@FuPingFranco FuPingFranco changed the title Removed Delegate Checks from Multiple Validators and Prevents Null Setting of Delegates Remove Delegate Checks in Multiple Validators and Prevents Null Setting of Delegates Jul 24, 2024
@FuPingFranco FuPingFranco requested a review from iNinja July 25, 2024 01:43
iNinja
iNinja approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@iNinja iNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, other than that LGTM.

src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs Show resolved Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs Show resolved Hide resolved
src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs Outdated Show resolved Hide resolved
@FuPingFranco FuPingFranco merged commit bb9a6d9 into dev Jul 27, 2024
4 checks passed
alexholub113
alexholub113 reviewed Jul 27, 2024
View reviewed changes
src/Microsoft.IdentityModel.Tokens/Validation/ValidationParameters.cs
}
set
{
_audienceValidator = value ?? throw new ArgumentNullException(nameof(value), "AudienceValidator cannot be set as null.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider to use nameof in exception message
nameof(ValidationParameters.AudienceValidator)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexholub113 alexholub113 alexholub113 left review comments

@brentschmaltz brentschmaltz brentschmaltz left review comments

@MZOLN MZOLN MZOLN approved these changes

@iNinja iNinja iNinja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FuPingFranco @iNinja @brentschmaltz @alexholub113 @MZOLN