Remove dependency on AadIssuerValidator.GetTenantIdFromToken in ValidateIssuerSigningKey #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoK
reviewed
Jul 2, 2024
pmaytak
reviewed
Jul 2, 2024
test/Microsoft.IdentityModel.Validators.Tests/AadSigningKeyIssuerValidatorTests.cs
Show resolved
Hide resolved
msbw2
reviewed
Jul 2, 2024
src/Microsoft.IdentityModel.Validators/AadTokenValidationParametersExtension.cs
Outdated
Show resolved
Hide resolved
msbw2
reviewed
Jul 2, 2024
src/Microsoft.IdentityModel.Validators/AadTokenValidationParametersExtension.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Validators/AadTokenValidationParametersExtension.cs
Show resolved
Hide resolved
brentschmaltz
approved these changes
Jul 3, 2024
pmaytak
reviewed
Jul 3, 2024
test/Microsoft.IdentityModel.Validators.Tests/AadSigningKeyIssuerValidatorTests.cs
Show resolved
Hide resolved
pmaytak
reviewed
Jul 3, 2024
src/Microsoft.IdentityModel.Validators/AadTokenValidationParametersExtension.cs
Outdated
Show resolved
Hide resolved
pmaytak
approved these changes
Jul 3, 2024
msbw2
reviewed
Jul 3, 2024
keegan-caruso
added a commit
that referenced
this pull request
Jul 8, 2024
…ateIssuerSigningKey (#2680) * Remove dep on AadIssuerValidator * Add DontFailOnMissingTidValidateIssuerSigning AppContextSwitch * Fail if multiple tids --------- Co-authored-by: Keegan Caruso <keegancaruso@microsoft.com>
keegan-caruso
added a commit
that referenced
this pull request
Jul 8, 2024
…ateIssuerSigningKey (#2680) * Remove dep on AadIssuerValidator * Add DontFailOnMissingTidValidateIssuerSigning AppContextSwitch * Fail if multiple tids --------- Co-authored-by: Keegan Caruso <keegancaruso@microsoft.com>
This was referenced Jul 8, 2024
Merged
Merged
keegan-caruso
added a commit
that referenced
this pull request
Jul 9, 2024
* Remove dependency on AadIssuerValidator.GetTenantIdFromToken in ValidateIssuerSigningKey (#2680) * Remove dep on AadIssuerValidator * Add DontFailOnMissingTidValidateIssuerSigning AppContextSwitch * Fail if multiple tids --------- Co-authored-by: Keegan Caruso <keegancaruso@microsoft.com> * Update langver for tests --------- Co-authored-by: Keegan Caruso <keegancaruso@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on AadIssuerValidator.GetTenantIdFromToken in ValidateIssuerSigningKey
Description
Removes the AadIssuerValidator.GetTenantIdFromToken dependency with an AppContext switch to fallback to previous behavior