Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding intent of variables to their name #2674

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

JoshLozensky
Copy link
Contributor

@JoshLozensky JoshLozensky commented Jun 27, 2024

Claims are checked in three different places while these variables are only intended to be used in one of those three places so the rename adds the place they are supposed to be used in, which is SecurityTokenDescriptor.Claims.

No logic is changed just local variable names for easier code readability.

@JoshLozensky JoshLozensky requested a review from a team as a code owner June 27, 2024 23:28
@JoshLozensky JoshLozensky merged commit cb39931 into dev Jun 28, 2024
4 checks passed
@JoshLozensky JoshLozensky deleted the lozensky/clearerVariableNames branch June 28, 2024 22:38
@jennyf19 jennyf19 added this to the 8.0.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants