Use Base64.DecodeFromUtf8InPlace #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegan-caruso
commented
Feb 28, 2024
benchmark/Microsoft.IdentityModel.Benchmarks/Microsoft.IdentityModel.Benchmarks.csproj
Show resolved
Hide resolved
MZOLN
reviewed
Feb 28, 2024
MZOLN
reviewed
Feb 28, 2024
sruke
reviewed
Feb 29, 2024
sruke
reviewed
Feb 29, 2024
| byte[] output = ArrayPool<byte>.Shared.Rent(outputSize); | ||
| try | ||
| { | ||
| Base64UrlEncoding.Decode(strSpan, startIndex, length, output); | ||
| ReadOnlySpan<char> slice = strSpan.Slice(startIndex, length); | ||
| Base64UrlEncoder.UnsafeDecode(slice, output); |
There was a problem hiding this comment.
Base64UrlEncoding.Decode(..) was throwing ArgumentOutOfRangeException and ArgumentException exceptions. The new code path will not throw these exceptions. We might want to share this in the release notes.
There was a problem hiding this comment.
yes, good idea.
sruke
reviewed
Feb 29, 2024
5e516ed to
38d9b18
Compare
7440712 to
487d7ef
Compare
pmaytak
reviewed
Apr 4, 2024
pmaytak
reviewed
Apr 5, 2024
pmaytak
reviewed
Apr 5, 2024
pmaytak
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Approved with suggestions. The code looks like it matches the previous one (except using the DecodeFromUtf8InPlace). Main suggestions are about refactoring a bit of the duplicate code. This class was a bit difficult to review since there are similarly named methods, duplicate code, and .NET6+ flags.
pmaytak
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Base64.DecodeFromUtf8InPlace for base64 decode
Description
Base64.DecodeFromUtf8InPlace is SIMD aware.
CPU: ~ -12% on token read time
before:
after:
Note: this was run with a cpu with the following intrinsics: AVX-512F+CD+BW+DQ+VL+VBMI