Improve Json serialization by always reading a complete object. #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/Microsoft.IdentityModel.Tokens.Tests/Json/JsonSerializerPrimitivesTests.cs
Show resolved
Hide resolved
...Microsoft.IdentityModel.Protocols.OpenIdConnect/Json/OpenIdConnectConfigurationSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Feb 13, 2024
...Microsoft.IdentityModel.Protocols.OpenIdConnect/Json/OpenIdConnectConfigurationSerializer.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.Tokens.Tests/Json/JsonSerializerPrimitivesTests.cs
Outdated
Show resolved
Hide resolved
308c541 to
652a173
Compare
jennyf19
approved these changes
Feb 21, 2024
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
This was referenced Feb 21, 2024
Remove test code that is no longer needed.
652a173 to
2abca63
Compare
This was referenced Feb 21, 2024
|
I'm wishing for a release with this fix ASAP, been spending days trying to understand and workaround incorrect parsing of |
1 task
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, when reading a JsonToken read the entire token and position the reader at the next token.
When reading a JsonObject, the reader was positioned at a JsonTokenType.EndObject after reading.
If the runtime was currently reading a JsonObject, the exit condition of seeing a JsonTokenType.EndObject would be true and the serialization would exit. Same was true for JsonArray.
This will make it very difficult for embedded objects.
Tests were added to ensure that Arrays and Objects placed in the beginning, middle or end of the Json text will be processed correctly.
Test code was removed that was used to understand how the previous internal Newtonsoft, System.Text.Json and external Newtonsoft would work together.
That code is no longer needed as we are dealing with issues as they arise.