Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marcinzo/issuervalidatormetadata #2480

Merged
merged 10 commits into from
Feb 24, 2024
Merged

Marcinzo/issuervalidatormetadata #2480

merged 10 commits into from
Feb 24, 2024

Conversation

MZOLN
Copy link
Contributor

@MZOLN MZOLN commented Feb 3, 2024

PoC injecting metadata configuration managers from outside for single point cache management

This PR adds injection point to AadIssuerValidator for ConfigurationManager

Description

This PR allows for centralized cache management, including http policies, lifetime policies, etc. and reduces the amount of copies
of cached data.

This is a conservative change, that still utilizes prev mechanism for a fallback in case the cache cannot be retrieved.

{Detail}

Fixes #{bug number} (in this specific format)

brentschmaltz
brentschmaltz requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examine if LKG should be set in AADIssuerValidator.

@MZOLN MZOLN force-pushed the marcinzo/issuervalidatormetadata branch from 95dfb3a to 6446b9f Compare February 22, 2024 22:54
@MZOLN MZOLN requested a review from brentschmaltz February 23, 2024 02:51
@MZOLN MZOLN force-pushed the marcinzo/issuervalidatormetadata branch from 0bae247 to 12267cf Compare February 23, 2024 20:29
@MZOLN MZOLN force-pushed the marcinzo/issuervalidatormetadata branch from 12267cf to 42c88ac Compare February 23, 2024 22:50
@MZOLN MZOLN merged commit d28f795 into dev Feb 24, 2024
5 checks passed
@MZOLN MZOLN deleted the marcinzo/issuervalidatormetadata branch February 24, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@brentschmaltz brentschmaltz brentschmaltz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MZOLN @brentschmaltz @keegan-caruso