Fix empty x5c header on JwtHeader #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2024 14:06
GetStandardHeader is used for first class properties on JwtHeader, one of these first class properties can be an array. Refactor to accomadate this. MultipleX5C test didn't properly exercise the header x5c API. Another test was added to show x5c can be roundtripped as well as that the value is equivalent between being fetched from a JwtSecurityToken or a JsonWebToken
jennyf19
reviewed
Jan 26, 2024
| @@ -80,7 +80,7 @@ public static Exception CreateJsonReaderExceptionInvalidType(ref Utf8JsonReader | |||
| LogHelper.MarkAsNonPII(reader.BytesConsumed))); | |||
| } | |||
|
|
|||
| public static JsonElement CreateJsonElement(List<string> strings) | |||
| public static JsonElement CreateJsonElement(IList<string> strings) | |||
There was a problem hiding this comment.
can we avoid the IList? #2242 (comment)
There was a problem hiding this comment.
IList covers a lot of types...
jennyf19
reviewed
Jan 26, 2024
| JsonElement json = JsonPrimitives.CreateJsonElement(stringList); | ||
| return json.ToString(); | ||
| } | ||
|
|
||
| // TODO - review dev | ||
| return string.Empty; |
There was a problem hiding this comment.
do you know what this is for?
jennyf19
reviewed
Jan 26, 2024
test/System.IdentityModel.Tokens.Jwt.Tests/CreateAndValidateTokens.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Jan 26, 2024
jennyf19
reviewed
Jan 26, 2024
GeoK
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetStandardClaim is used for first class
properties on JwtHeader, one of these first class
properties can be an array. Refactor to accomadate this.
MultipleX5C test didn't properly exercise the
header x5c API.
Another test was added to show x5c can be
roundtripped as well as that the value is equivalent between being fetched from a JwtSecurityToken or a JsonWebToken
Fixes #2447