-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding P50, P90 and P100 percentiles to benchmarks #2411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
benchmark/Microsoft.IdentityModel.Benchmarks/AntiVirusFriendlyConfig.cs
Outdated
Show resolved
Hide resolved
benchmark/Microsoft.IdentityModel.Benchmarks/AntiVirusFriendlyConfig.cs
Outdated
Show resolved
Hide resolved
|
||
namespace Microsoft.IdentityModel.Benchmarks | ||
{ | ||
// Define custom columns for P50 and P99 latency | ||
public class P50Column : IColumn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://benchmarkdotnet.org/articles/features/statistics.html
Most of these look like they already exist in StatisticColumn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. The columns explicitly get the ones we want and not the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments are off, otherwise LGTM
Adding P50, P90 and P100 percentiles to benchmarks
Adds 3 columns to the benchmark summaries to display the P50, P90 and P100 percentiles
Description
The benchmark summaries now contains the pecentiles
Fixes #2410