Support serialization for common scenarios #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix 2038 datetime issue
jennyf19
reviewed
Aug 28, 2023
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 28, 2023
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenTests.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 28, 2023
jennyf19
reviewed
Aug 28, 2023
jennyf19
reviewed
Aug 28, 2023
| } | ||
|
|
||
| if (typeof(T) == typeof(object[])) | ||
| return (T)(object)new object[] { obj }; |
There was a problem hiding this comment.
Looks like we are missing test coverage for these
jennyf19
reviewed
Aug 28, 2023
jennyf19
reviewed
Aug 28, 2023
jennyf19
reviewed
Aug 28, 2023
src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonWebToken.HeaderClaimSet.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 28, 2023
src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonWebToken.PayloadClaimSet.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 28, 2023
src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonWebToken.PayloadClaimSet.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 28, 2023
src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonWebToken.PayloadClaimSet.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 28, 2023
jennyf19
reviewed
Aug 28, 2023
jennyf19
reviewed
Aug 28, 2023
|
|
||
| return (T)(object)items; | ||
| } | ||
| else if (typeof(T) == typeof(long[])) |
There was a problem hiding this comment.
do we have tests for these else ifs?
jennyf19
reviewed
Aug 28, 2023
src/Microsoft.IdentityModel.Tokens/Json/JsonSerializerPrimitives.cs
Outdated
Show resolved
Hide resolved
14 tasks
added 2 commits
August 28, 2023 17:35
keegan-caruso
approved these changes
Aug 29, 2023
brentschmaltz
added a commit
that referenced
this pull request
Sep 6, 2023
* Support serialization for common scenarios fix 2038 datetime issue * addressed some PR comments * missed a comma * removed some commented code * reorder to fix references --------- Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
brentschmaltz
added a commit
that referenced
this pull request
Sep 7, 2023
* Support serialization for common scenarios fix 2038 datetime issue * addressed some PR comments * missed a comma * removed some commented code * reorder to fix references --------- Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to the support 'T' that were available in 6x.
Fix 2038 datetime issue with JwtSecurityToken
If possible, Json will be mapped to one of the following types:
string[], List,,Collection, object[], List, Collection, int[], long[]
Dictionary<string, string>>, Dictionary<string, string[]>, Dictionary<string, List>, Dictionary<string, Collection>
Dictionary<string, object>, Dictionary<string, object[]>
With this change 7 will not be as general as 6x but will help with common scenarios.
A general solution will require a new api.
When calling TryGetPayloadValue the priority is generally:
sting, string[], List, Collection, ...
=================================
Pattern matching is applied when possible.
Json = {“p”:[1,2,3]}
TryGetPayLoadValue<string[]>(“p”) => string[]{“1”,”2”,”3”}
Json = {“p”:”value”}
TryGetPayLoadValue<string[]>(“p”) => string[]{“value”}
Json = {“p”:{”object”:”value”}}
TryGetPayLoadValue(“p”) => “{“object”:”value”}”
This will always return a value if it was the property exists.
=====================================
We still write obj.ToString() when serializing, even if we don't understand the type, as users that are working with Newtosoft.JObject will benefit. We are open to changing this depending on feedback.