Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark synchronous wrapper as obsolete #2263

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Mark synchronous wrapper as obsolete #2263

merged 5 commits into from
Aug 28, 2023

Conversation

westin-m
Copy link
Contributor

Fixes #2253

@keegan-caruso keegan-caruso linked an issue Aug 25, 2023 that may be closed by this pull request
[Bug] Remove sync-over-async patterns in 7x. #2253
Closed
@westin-m westin-m force-pushed the westinm/syncAsyncBug branch 2 times, most recently from 9412ba9 to e09333f Compare August 25, 2023 22:02
@westin-m westin-m force-pushed the westinm/syncAsyncBug branch from e09333f to 8a002de Compare August 25, 2023 22:08
@westin-m westin-m force-pushed the westinm/syncAsyncBug branch from 8a002de to 727525e Compare August 25, 2023 22:10
@jennyf19
Copy link
Collaborator

Can you update the tests which are using the deprecated method? This way we will not get warnings in the build either.

jennyf19
jennyf19 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks @westin-m

@westin-m westin-m added this pull request to the merge queue Aug 28, 2023
Merged via the queue into dev7 with commit 9e87d9b Aug 28, 2023
@westin-m westin-m deleted the westinm/syncAsyncBug branch August 28, 2023 17:48
brentschmaltz pushed a commit that referenced this pull request Sep 6, 2023
@westin-m
Mark synchronous wrapper as obsolete (#2263)
216b908 
* Mark synchronous wrapper as obsolete

* fix link

* Edit tests to no longer use obsolete method

* Clear up use of obsolete method
brentschmaltz pushed a commit that referenced this pull request Sep 7, 2023
@westin-m @brentschmaltz
Mark synchronous wrapper as obsolete (#2263)
9cdf5d4 
* Mark synchronous wrapper as obsolete

* fix link

* Edit tests to no longer use obsolete method

* Clear up use of obsolete method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Remove sync-over-async patterns in 7x.
3 participants
@westin-m @jennyf19 @keegan-caruso