First cut at OpenIdConnectConfiguration and SignedHttpRequest #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.IdentityModel.Protocols.OpenIdConnect/OpenIdConnectParameterNames.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols.OpenIdConnect/OpenIdConnectParameterNames.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols.OpenIdConnect/OpenIdProviderMetadataNames.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
jennyf19
reviewed
Aug 10, 2023
src/Microsoft.IdentityModel.Protocols.OpenIdConnect/Configuration/OpenIdConnectConfiguration.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
...Microsoft.IdentityModel.Protocols.OpenIdConnect/Json/OpenIdConnectConfigurationSerializer.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
...Microsoft.IdentityModel.Protocols.OpenIdConnect/Json/OpenIdConnectConfigurationSerializer.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
...Microsoft.IdentityModel.Protocols.OpenIdConnect/Json/OpenIdConnectConfigurationSerializer.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
...Microsoft.IdentityModel.Protocols.OpenIdConnect/Json/OpenIdConnectConfigurationSerializer.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/OpenIdConnectMessageTests.cs
Show resolved
Hide resolved
jennyf19
reviewed
Aug 10, 2023
test/Microsoft.IdentityModel.Protocols.OpenIdConnect.Tests/Json/OpenIdConnectConfiguration6x.cs
Show resolved
Hide resolved
...Microsoft.IdentityModel.Protocols.OpenIdConnect/Json/OpenIdConnectConfigurationSerializer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/SignedHttpRequestHandler.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 11, 2023
brentschmaltz
added a commit
that referenced
this pull request
Sep 6, 2023
* First cut at OpenIdConnectConfiguration and SignedHttpRequest * addressed review comments --------- Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
brentschmaltz
added a commit
that referenced
this pull request
Sep 7, 2023
* First cut at OpenIdConnectConfiguration and SignedHttpRequest * addressed review comments --------- Co-authored-by: Brent Schmaltz <brentsch@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes remove the use of Newtonsoft from OpenIdConnectConfiguration and OpenIdConnectMessage completely.
SignedHttpRequestHandler still has some dependency on usage in JsonWebTokenHandler. That will be next.
The serialization of OpenIdConnectConfiguration follows the pattern of JsonWebKey and JsonWebKeySet.
SignedHttpRequestHandler changes were mostly related to using Utf8JsonReader/Writers all the through the stack rather than creating temporary strings that need to be transformed back utf8bytes.
This led to a number of changes in the SignedHttpRequestHandler tests.
The tests that checked for a null payload were no longer needed as the temporary dictionary is not used anymore.