Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding nullable into extensions dir #2203

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Adding nullable into extensions dir #2203

merged 1 commit into from
Aug 4, 2023

Conversation

FuPingFranco
Copy link
Contributor

Added Nullables into extensions dir.

@FuPingFranco FuPingFranco marked this pull request as ready for review August 3, 2023 18:07
@jmprieur
Copy link
Contributor

jmprieur commented Aug 3, 2023

@FuPingFranco
The work should be done in the src only, in the dependency order (from the top to the bottom)

image

jmprieur
jmprieur approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @FuPingFranco

src/Microsoft.IdentityModel.KeyVaultExtensions/KeyVaultSecurityKey.cs Show resolved Hide resolved
@FuPingFranco
Copy link
Contributor Author

FuPingFranco commented Aug 3, 2023 •
edited
Loading

@FuPingFranco The work should be done in the src only, in the dependency order (from the top to the bottom)

image

Yes, this PR was intended for the logging extensions as depicted on the code map however, I did some experimenting and didn't see any major impact on this PR by adding the remaining dll's in the extensions dir.

@jmprieur
Copy link
Contributor

jmprieur commented Aug 3, 2023 •
edited
Loading

That's good news, @FuPingFranco

Maybe we want to have a list of checkboxes (so that we know what is done, and what is coming next)?

  • Abstractions
  • Logging
  • LoggingExtensions
  • Tokens

etc ...
?

@FuPingFranco
Copy link
Contributor Author

That's good news, @FuPingFranco

Maybe we want to have a list of checkboxes (so that we know what is done, and what is coming next)?

  • Abstractions
  • Logging
  • LoggingExtensions
  • Tokens

etc ... ?

I agree, I will create one on ADO to keep track of this. Thanks Jean-Marc!

@FuPingFranco FuPingFranco added this pull request to the merge queue Aug 4, 2023
Merged via the queue into dev7 with commit 6879c00 Aug 4, 2023
brentschmaltz pushed a commit that referenced this pull request Sep 6, 2023
@FuPingFranco
Adding nullable into extensions dir (#2203)
b3b8763 
Co-authored-by: Franco Fung <francofung@microsoft.com>
brentschmaltz pushed a commit that referenced this pull request Sep 7, 2023
@FuPingFranco @brentschmaltz
Adding nullable into extensions dir (#2203)
91b3038 
Co-authored-by: Franco Fung <francofung@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MZOLN MZOLN MZOLN left review comments

@keegan-caruso keegan-caruso keegan-caruso approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FuPingFranco @jmprieur @jennyf19 @keegan-caruso @MZOLN