Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid draining the ArrayPool with undisposed JsonDocuments #2178

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Avoid draining the ArrayPool with undisposed JsonDocuments #2178

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98e0889
Avoid draining the ArrayPool with undisposed JsonDocuments
stephentoub Jul 26, 2023
a06c836
Update src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonClaimSet.cs
stephentoub Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/Microsoft.IdentityModel.JsonWebTokens/Json/JsonClaimSet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,16 @@ internal class JsonClaimSet

internal JsonClaimSet(JsonDocument jsonDocument)
{
RootElement = jsonDocument.RootElement;
RootElement = jsonDocument.RootElement.Clone();
stephentoub marked this conversation as resolved.
Show resolved Hide resolved
jsonDocument.Dispose();
}

internal JsonClaimSet(byte[] jsonBytes)
internal JsonClaimSet(byte[] jsonBytes) : this(JsonDocument.Parse(jsonBytes))
{
RootElement = JsonDocument.Parse(jsonBytes).RootElement;
}

internal JsonClaimSet(string json)
internal JsonClaimSet(string json) : this(JsonDocument.Parse(json))
{
RootElement = JsonDocument.Parse(json).RootElement;
}

internal JsonElement RootElement { get; }
Expand Down