-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial addition of Nullable property to Abstractions Project. #2139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @FuPingFranco
Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
src/Microsoft.IdentityModel.Protocols.SignedHttpRequest/GlobalSuppressions.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @FuPingFranco
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
* Initial addition of Nullable property to Abstractions Project. * Update build/common.props Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com> * Added nullable to WsFederation project. --------- Co-authored-by: Franco Fung <francofung@microsoft.com> Co-authored-by: Westin Musser <127992899+westin-m@users.noreply.github.com>
Initial PR to Abstractions project to enable nullable across the solution allowing variables to have null as a value, which can be useful in cases where a value may not be present or when a value is optional. It also allows for the use of null-forgiving operator, which suppresses nullable warnings for an expression.