Possible fixes to address perf issue in 6.31 #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug: - the constructor of JSonWebToken taking header and payload supposes that these are json, not encoded. They should not be assigned directly to the encoded members. This is likely to provoke plenty of exception. - the potential exception: in ToString(), we don't verify that there is at least one dot. Again could provoke an exception on malformed tokens.
henrik-me
reviewed
Jul 10, 2023
jmprieur
reviewed
Jul 11, 2023
GeoK
approved these changes
Jul 11, 2023
jmprieur
approved these changes
Jul 11, 2023
dannybtsai
reviewed
Jul 11, 2023
| { | ||
| if (arg == null) | ||
| return "null"; | ||
|
|
||
| if (arg is ISafeLogSecurityArtifact && IdentityModelEventSource.LogCompleteSecurityArtifact) | ||
| if (IdentityModelEventSource.LogCompleteSecurityArtifact && arg is ISafeLogSecurityArtifact) |
There was a problem hiding this comment.
Use in-line is operator:
if (IdentityModelEventSource.LogCompleteSecurityArtifact && arg is ISafeLogSecurityArtifact safeLogSecurityArtifact)
return safeLogSecurityArtifact.UnsafeToString();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.