updated fix for controlling depth. #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we fork newtonsoft do we normally pull in their tests too are do we assume we'd catch a regression here another way --OR-- are we simply saying that since since we don't intend to touch this code we're relying on the newtonsoft tests running in their repo? Other than that LGTM. I think generally if we have the code in our repo we should have the tests in our repo too. |
TimHannMSFT
approved these changes
Feb 15, 2023
|
@TimHannMSFT i didn't see any test code for NewtonSoft in our branch. |
This was referenced Mar 28, 2023
renovate bot
referenced
this pull request
in orso-co/Orso.Arpa.Api
Apr 7, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [System.IdentityModel.Tokens.Jwt](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet) | nuget | minor | `6.27.0` -> `6.28.1` | --- ### Release Notes <details> <summary>AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet</summary> ### [`v6.28.1`](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.28.1) [Compare Source](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.28.0...6.28.1) - Bug fix where internal cache was not instantiated [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2045](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2045) ### [`v6.28.0`](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/releases/tag/6.28.0) [Compare Source](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/compare/6.27.0...6.28.0) - Enrich metadata failure message during metadata refresh interval [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2010](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2010) - Updated fix for controlling depth [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2024](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2024) - Update Wilson logs with aka.ms pointers to known wikis in [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2027](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2027) - Fix typo in documentation [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2034](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2034) - Introduce a LKG configuration cache to store each valid base configuration instead of a single entry of configuration [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2007](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2007) - Add encryption keys to base configuration [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2023](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2023) - Updated CHANGELOG link [https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2026](https://togithub.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/pull/2026) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up a fix for controlling depth of parsing.