Add SecurityTokenSignatureKeyNotFoundWithValidationErrorsException #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecurityTokenSignatureKeyNotFoundWithValidationErrorsException represents SecurityTokenSignatureKeyNotFoundException but with validation errors such that a different signal is sent to the layer above
GeoK
reviewed
Mar 19, 2021
GeoK
reviewed
Mar 19, 2021
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Mar 19, 2021
test/Microsoft.IdentityModel.Tokens.Saml.Tests/SamlSecurityTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Mar 19, 2021
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
Outdated
Show resolved
Hide resolved
GeoK
reviewed
Mar 20, 2021
GeoK
reviewed
Mar 20, 2021
...ityModel.Tokens/Exceptions/SecurityTokenSignatureKeyNotFoundWithValidationErrorsException.cs
Outdated
Show resolved
Hide resolved
|
Conceptually looks good. |
SecurityTokenSignatureKeyNotFoundWithValidationErrorsException is not a signal for metadata refresh
Update message to indicate it is not used for metadata refresh
Remove SecurityTokenSignatureKeyNotFoundWithValidationErrorsException and use SecurityTokenUnableToValidateException instead, allowing the single exception type to express different types of validation failures Add ValidationFailure as a bit field enum
GeoK
reviewed
Mar 23, 2021
src/Microsoft.IdentityModel.Tokens.Saml/Saml/SamlSecurityTokenHandler.cs
Outdated
Show resolved
Hide resolved
mafurman
reviewed
Mar 26, 2021
src/Microsoft.IdentityModel.Tokens/Exceptions/SecurityTokenUnableToValidateException.cs
Outdated
Show resolved
Hide resolved
mafurman
reviewed
Mar 26, 2021
mafurman
reviewed
Mar 26, 2021
GeoK
approved these changes
Mar 29, 2021
test/Microsoft.IdentityModel.JsonWebTokens.Tests/JsonWebTokenHandlerTests.cs
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SecurityTokenSignatureKeyNotFoundWithValidationErrorsException represents
SecurityTokenSignatureKeyNotFoundException but with validation errors
such that a different signal is sent to the layer above