comments from review

AzureAD · Jun 20, 2023 · a630cc9 · a630cc9
1 parent 7fc29ae
commit a630cc9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/System.IdentityModel.Tokens.Jwt/JwtSecurityTokenConverter.cs b/src/System.IdentityModel.Tokens.Jwt/JwtSecurityTokenConverter.cs
@@ -6,7 +6,7 @@
 namespace System.IdentityModel.Tokens.Jwt
 {
     /// <summary>
-    /// Static class to converts an object to a <see cref="JwtSecurityToken"/>
+    /// Static class to convert a <see cref="JsonWebToken"/> to a <see cref="JwtSecurityToken"/>
     /// </summary>
     public static class JwtSecurityTokenConverter
     {

diff --git a/test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenConverterTests.cs b/test/System.IdentityModel.Tokens.Jwt.Tests/JwtSecurityTokenConverterTests.cs
@@ -29,22 +29,22 @@ public void JsonWebTokenToJwtSecurityTokenConversions(JwtSecurityTokenConverterT
 
         public static TheoryData<JwtSecurityTokenConverterTheoryData> ConverterTheoryData()
         {
-            var tdJwe = new SecurityTokenDescriptor
+            var tokenDescriptorJwe = new SecurityTokenDescriptor
             {
                 SigningCredentials = KeyingMaterial.JsonWebKeyRsa256SigningCredentials,
                 EncryptingCredentials = KeyingMaterial.DefaultSymmetricEncryptingCreds_Aes256_Sha512_512,
                 Claims = Default.PayloadDictionary
             };
 
-            var tdJws = new SecurityTokenDescriptor
+            var tokenDescriptorJws = new SecurityTokenDescriptor
             {
                 SigningCredentials = KeyingMaterial.JsonWebKeyRsa256SigningCredentials,
                 Claims = Default.PayloadDictionary
             };
 
             var handler = new JsonWebTokenHandler();
-            var jweTokenString = handler.CreateToken(tdJwe);
-            var jwsTokenString = handler.CreateToken(tdJws);
+            var jweTokenString = handler.CreateToken(tokenDescriptorJwe);
+            var jwsTokenString = handler.CreateToken(tokenDescriptorJws);
 
             var validationParameters = new TokenValidationParameters
             {
@@ -103,7 +103,7 @@ public static TheoryData<JwtSecurityTokenConverterTheoryData> ConverterTheoryDat
                         foreach (var claim in jweTokenClaims)
                         {
                             Assert.True(otherTokenClaims.ContainsKey(claim.Key));
-                            Assert.True(otherTokenClaims[claim.Key] == claim.Value);
+                            Assert.Equal(otherTokenClaims[claim.Key], claim.Value);
                         }
 
                     }
@@ -131,7 +131,7 @@ public static TheoryData<JwtSecurityTokenConverterTheoryData> ConverterTheoryDat
                         foreach (var claim in jwsTokenFromStringClaims)
                         {
                             Assert.True(otherTokenClaims.ContainsKey(claim.Key));
-                            Assert.True(otherTokenClaims[claim.Key] == claim.Value);
+                            Assert.Equal(otherTokenClaims[claim.Key], claim.Value);
                         }
                     }
                 },
@@ -158,7 +158,7 @@ public static TheoryData<JwtSecurityTokenConverterTheoryData> ConverterTheoryDat
                         foreach (var claim in jwsTokenFromHeaderAndPayloadClaims)
                         {
                             Assert.True(otherTokenClaims.ContainsKey(claim.Key));
-                            Assert.True(otherTokenClaims[claim.Key] == claim.Value);
+                            Assert.Equal(otherTokenClaims[claim.Key], claim.Value);
                         }
                     }
                 }