Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Workflow Generation for DevHub #1263

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ReinierCC
Copy link
Collaborator

@ReinierCC ReinierCC commented Feb 20, 2025

With this PR the backend is able to take in all the necesary input required to create the api call to DevHub to initate the workflow creation.

Significant updates to the src/panels/DevHubAutoDeployPanel.ts file to enhance the workflow creation process and improve the overall structure of the code. The changes involve refactoring the workflow creation logic to utilize parameters from the webview, reorganizing imports, and updating type definitions.

Refactoring and Enhancements:

  • Workflow Creation Logic:

    • Updated the handleCreateWorkflowRequest method to accept WorkflowCreationParams from the webview, replacing hardcoded values with dynamic inputs.
    • Modified the launchDevHubWorkflow function to use the parameters from WorkflowCreationParams for creating the workflow.
    • Enhanced the method to handle the creation of namespaces, ACRs, and role assignments based on the provided parameters. [1] [2] [3]
  • Imports and Type Definitions:

    • Moved type definitions for automated deployments panel to a new types.ts file and updated imports accordingly. [1] [2]

Changes are still NOT available to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant