Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webview UI toolkit deprecation] AttachAcrToCluster, DraftDeployment/Dockerfile/Workflow Panel component removal #1260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tejhan
Copy link
Collaborator

@tejhan tejhan commented Feb 20, 2025

This PR specifically removes elements from the AttachAcrToCluster & DraftDeployment/Dockerfile/Workflow commands.

.vsix for testing: vscode-aks-tools-1.6.0-deprecate3.vsix.zip

This is broken up as part of incremental PR's to make review & testing smoother.

For future reference:

  • .secondary-button replaces VSCodeButton's appearance="secondary"
  • .icon-button replaces VSCodeButton's appearance="icon"
  • input[type="text"] replaces VSCodeTextInput
  • input[type="checkbox"] replaces VSCodeCheckbox
  • input[type="radio"] replaces VSCodeRadio
  • Default "< hr >" element now has identical styling to VSCodeDivider
  • Default "< a >" element also has identical styling to VSCodeLink

@ReinierCC
Copy link
Collaborator

AttachAcrToCluster worked well. ✅

For DraftDeployment after clicking create there's some text fields that don't get greyed out. As well the selected deployment option no longer appears.

Before:
Screenshot 2025-02-21 at 11 03 43 AM

After:
Screenshot 2025-02-21 at 11 02 34 AM

Similar Issue with Draft Dockerfile & Workflow
Screenshot 2025-02-21 at 11 09 04 AM

Screenshot 2025-02-21 at 11 11 33 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants