Removing & replacing react elements from deprecated webview-ui-toolkit package. #1239
Conversation
|
Hey all, just pushed committed some recent changes. The remaining elements from the initial commits have been completely wiped, alongside radio group, radio inputs, & textfield inputs. The remaining elements like the dropdown buttons & panel tabs will have to be replaced by custom JS/React elements that can still mimic the structural functionality we already have, so I'm working on these now & they will be changed in the next incremental deprecation PR. Newest v6: |
There was a problem hiding this comment.
❤️ Nice work on this! 🎉 really appreciate the effort that went into this update.
One thought—would it make sense to break this down into feature-specific PRs? That way, if a bug pops up, it would only affect one or two commands rather than the entire set. Having a single PR with 44 files could make it tricky to track down issues if something doesn't work as expected.
Alternatively, we could do a smaller PR first to validate the core changes and follow up with a larger one once we confirm most of the deprecations work smoothly. What do you think? 😊
Fyi and thought share with @hsubramanianaks , @ReinierCC , @qpetraroia
I agree. Maybe we could also set up a doc to check off and distrubute which pages have been tested. |
There was a problem hiding this comment.
LGTM, we can either split few pages among us for testing and make sure it is tested in all platforms or we can separate it out based on some functionalities or usage based (4 PR's?? ) . I know kubectl run command, ASO, InspecktorGagdet are used in regular, we can do that as separate PR. Also CreateCluster and CreateFleet can be a separate one. Retina and tcpDump can be combined since they are similar.
This reminds me that we should have some automated testing for webview and extension functionalities so that we don't have to completely rely on Manual testing :).. Let's plan for it in the future. Thanks Tejhan.
Regarding the comments, good points, I will go ahead and break this down into smaller PR's. I can group related pages together. I'm wrapping up the final PR for deprecation which would be similarly large but I think I'll just break that up as well, so each can be quickly looked at and reviewed. I've tested out each change extensively myself but for the larger team to test it would be easier to split things up. |
This incremental PR serves to replace a large amount of react elements from the deprecated webview-ui-toolkit package.
Most prominently, almost all instances of VSCodeButton, VSCodeLink, VSCodeDivider, & VSCodeCheckbox have been completely removed & replaced with properly styled alternatives.
Other elements like VSCodeTextField, VSCodeDropdown haven't been fully replaced yet, but styles have been created & applied in some scenarios. (Our current implementation requires case by case changes for each instance, so we have to make sure to test for each case before blanket replacement.) Full replacement will come in follow up PR.
For future reference:
.vsix for testing:
vscode-aks-tools-1.5.5-ui-test.vsix.zip