Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

var.admin_username is required, var.admin_ssh_keys.*.username is optional and in case its present should be equal to var.admin_username #11

Conversation

juanjojulian
Copy link
Contributor

var.admin_username is required, var.admin_ssh_keys.*.username is optional and in case its present should be equal to var.admin_username

Describe your changes

  • var.admin_username is required and non nullable.
  • var.admin_ssh_keys.*.username is optional and in case its present should be equal to var.admin_username

Issue number

#000

Checklist before requesting a review

  • [ X ] The pr title can be used to describe what this pr did in CHANGELOG.md file
  • [ X ] I have executed pre-commit on my machine
  • [ X ] I have passed pr-check on my machine

Thanks for your cooperation!

…onal and in case its present should be equal to var.admin_username
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Potential Breaking Changes in 85a8a19:
[update] "Variables.admin_ssh_keys.Type" from 'set(object({
public_key = string
username = string
}))' to 'set(object({
public_key = string
username = optional(string)
}))'
[update] "Variables.admin_username.Default" from '"azureuser"' to ''
[update] "Variables.admin_username.Nullable" from '' to 'false'

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanjojulian for opening this pr! Some tiny issues that I'd like to solve, WDYT?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Potential Breaking Changes in 4f67050:
[update] "Variables.admin_ssh_keys.Type" from 'set(object({
public_key = string
username = string
}))' to 'set(object({
public_key = string
username = optional(string)
}))'
[update] "Variables.admin_username.Nullable" from '' to 'false'

Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanjojulian for the update, please add var.admin_username to outputs as you suggested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Potential Breaking Changes in 0defb81:
[update] "Variables.admin_ssh_keys.Type" from 'set(object({
public_key = string
username = string
}))' to 'set(object({
public_key = string
username = optional(string)
}))'
[update] "Variables.admin_username.Nullable" from '' to 'false'

@juanjojulian juanjojulian temporarily deployed to acctests February 13, 2023 01:41 — with GitHub Actions Inactive
Copy link
Member

@lonegunmanb lonegunmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanjojulian, LGTM! 🚀

@lonegunmanb lonegunmanb merged commit b501ff2 into Azure:main Feb 13, 2023
@juanjojulian juanjojulian deleted the admin_username-admin_ssh_keys.admin_ssh_keys branch February 13, 2023 05:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants