-
Notifications
You must be signed in to change notification settings - Fork 35
var.admin_username is required, var.admin_ssh_keys.*.username is optional and in case its present should be equal to var.admin_username #11
Conversation
…onal and in case its present should be equal to var.admin_username
Potential Breaking Changes in 85a8a19: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juanjojulian for opening this pr! Some tiny issues that I'd like to solve, WDYT?
Potential Breaking Changes in 4f67050: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juanjojulian for the update, please add var.admin_username
to outputs as you suggested.
Potential Breaking Changes in 0defb81: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @juanjojulian, LGTM! 🚀
var.admin_username is required, var.admin_ssh_keys.*.username is optional and in case its present should be equal to var.admin_username
Describe your changes
Issue number
#000
Checklist before requesting a review
CHANGELOG.md
fileThanks for your cooperation!