Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README example to supress network security ID warning #32

Merged
merged 6 commits into from
Feb 28, 2020

Conversation

danielfears
Copy link
Contributor

Raising pull request to address issue #113 on terraform-azurerm-compute module - Azure/terraform-azurerm-compute#113

Copy link
Contributor

@yupwei68 yupwei68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. A little adjustment would be perfect.

@@ -8,6 +8,7 @@ This Terraform module deploys a Virtual Network in Azure with a subnet or a set

The module does not create nor expose a security group. This would need to be defined separately as additional security rules on subnets in the deployed network.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the blank?

@yupwei68 yupwei68 merged commit a41a42e into Azure:master Feb 28, 2020
nmadesh20 pushed a commit to nmadesh20/terraform-azurerm-network that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants