Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use terramodtest package to run test kitchen tasks. #18

Merged
merged 4 commits into from
Feb 3, 2018
Merged

Use terramodtest package to run test kitchen tasks. #18

merged 4 commits into from
Feb 3, 2018

Conversation

metacpp
Copy link
Contributor

@metacpp metacpp commented Feb 2, 2018

This PR contains:

  1. Upgrade terramodtest v0.2.0 to get test-kitchen tasks support.
  2. Replace test-kitchen code in Rakefile with reusable task from gem package.
  3. Update Readme to contain "bundle install" before run "rake" build task.

@rguthriemsft
Copy link
Contributor

@dcaro, tested with vs code extension and everything looks good.

dcaro
dcaro approved these changes Feb 3, 2018
View reviewed changes
Copy link
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcaro dcaro merged commit 65f5a97 into master Feb 3, 2018
@rguthriemsft rguthriemsft deleted the test-kitchen branch February 6, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaro dcaro dcaro approved these changes

@JunyiYi JunyiYi Awaiting requested review from JunyiYi

@WodansSon WodansSon Awaiting requested review from WodansSon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metacpp @rguthriemsft @dcaro