Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make var.prefix optional #382

Merged
merged 3 commits into from
Jun 5, 2023
Merged

Make var.prefix optional #382

merged 3 commits into from
Jun 5, 2023

Conversation

lonegunmanb
Copy link
Member

@lonegunmanb lonegunmanb commented Jun 1, 2023 •
edited
Loading

Describe your changes

This pr is based on @withersj888's work on #359.

Issue number

#308

Checklist before requesting a review

  • The pr title can be used to describe what this pr did in CHANGELOG.md file
  • I have executed pre-commit on my machine
  • I have passed pr-check on my machine

Thanks for your cooperation!

@lonegunmanb lonegunmanb temporarily deployed to acctests June 1, 2023 05:53 — with GitHub Actions Inactive
@lonegunmanb lonegunmanb temporarily deployed to acctests June 2, 2023 02:17 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Potential Breaking Changes in 2c4aa1d:
[update] "Variables.prefix.Nullable" from '' to 'false'

@lonegunmanb lonegunmanb added this to the 7.1.0 milestone Jun 2, 2023
jiaweitao001
jiaweitao001 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@jiaweitao001 jiaweitao001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lonegunmanb lonegunmanb merged commit 0ae8a66 into Azure:main Jun 5, 2023
@lonegunmanb lonegunmanb mentioned this pull request Jun 5, 2023
Closed
3 tasks
@lonegunmanb lonegunmanb deleted the e-308 branch June 30, 2023 09:35
skolobov pushed a commit to skolobov/terraform-azurerm-aks that referenced this pull request Oct 29, 2023
@lonegunmanb @skolobov
Make var.prefix optional (Azure#382)
d4649fb 
* make var.prefix optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiaweitao001 jiaweitao001 jiaweitao001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lonegunmanb @jiaweitao001