Added one more rule for response validation in model validation. #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail the validation when there's schema defined for response body in spec but the example response doesn't provide the body in response.
Coverage for the new added rules about body/schema validation in response.
nschonni
reviewed
Jul 2, 2019
ChangeLog.md
Outdated
| @@ -1,8 +1,10 @@ | |||
| # Changelog | |||
| ### 07/02/2019 0.18.5 | |||
There was a problem hiding this comment.
0.18.5 was published on June 12th d54eaf3
Suggested change
| ### 07/02/2019 0.18.5 | |
| ### 06/12/2019 0.18.5 |
sergey-shandar
approved these changes
Jul 2, 2019
amarzavery
suggested changes
Jul 2, 2019
|
@amarzavery , the fix was submitted, please review. |
amarzavery
approved these changes
Jul 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail the validation when there's schema defined for response body in spec but the example
response doesn't provide the body in response.