Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match types version of uuid #465

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Match types version of uuid #465

merged 2 commits into from
Mar 1, 2022

Conversation

alexrecuenco
Copy link
Contributor

UUID was updated to 8.3.2, but @types/uuid was still using the 3.x version

UUID was updated to 8.3.2, but @types/uuid was still using the 3.x version
@alexrecuenco alexrecuenco changed the title Match types definition of uuid Match types version of uuid Feb 28, 2022
@jeremymeng
Copy link
Member

@alexrecuenco thank you very much for your contribution! The change looks good. I am curious about your usage on @azure/ms-rest-js. What functionality are you using? If you are just using the http client, I want to let you know that we have created a new package @azure/core-rest-pipeline and made a lot of improvements there.

@jeremymeng
Copy link
Member

@deyaaeldeen It looks that the Test autorest.typescript build pipeline is failing likely because .NET core 2.0 is no longer available in vm image. The test is using v4x branch. Is it possible to either add a step to install .NET Core 2.0, or upgrade to use later version of .NET.

@jeremymeng
Copy link
Member

Merging. The build failure is unrelated.

@jeremymeng jeremymeng merged commit e968192 into Azure:master Mar 1, 2022
@alexrecuenco
Copy link
Contributor Author

@alexrecuenco thank you very much for your contribution! The change looks good. I am curious about your usage on @azure/ms-rest-js. What functionality are you using? If you are just using the http client, I want to let you know that we have created a new package @azure/core-rest-pipeline and made a lot of improvements there.

I am using it indirectly through the bot framework. I was exploring how some internals work and noticed the dependency inconsistency, so I thought it would be helpful to provide a PR for the small change

@alexrecuenco alexrecuenco deleted the patch-1 branch March 1, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants