-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --no-bastion to allow users to opt-out of Bastion host and Jumpbox creation #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooke-hamilton
approved these changes
May 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deployed with and without Bastion. 👍
jwaltireland
pushed a commit
to ARPA-H/AzureMissionLZ
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change proposes a
--no-bastion
flag to CLI deployments that allow a user to opt-out of deploying an Azure Bastion Host and Windows virtual machine jumpbox into the Hub network.To try this out, add the
--no-bastion
flag to a deployment like:There is one known issue: as of this PR, users are not able to opt out of Bastion Host and Jumpbox deployments from the UI. This limitation is tracked here: #213-- this was fixed with #218Issue reference
The issue this PR will close: #189
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck
.vscode/extensions.json
.)